[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202302070311.gE92izdH-lkp@intel.com>
Date: Tue, 7 Feb 2023 04:07:58 +0800
From: kernel test robot <lkp@...el.com>
To: Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, Jakub Kicinski <kuba@...nel.org>,
Eric Dumazet <edumazet@...gle.com>,
Jonathan Corbet <corbet@....net>,
Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v3 net-next 1/4] net-sysctl: factor out cpumask parsing
helper
Hi Paolo,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/intel-lab-lkp/linux/commits/Paolo-Abeni/net-sysctl-factor-out-cpumask-parsing-helper/20230207-023315
patch link: https://lore.kernel.org/r/f171c4f78c17c259deb0cae78a26dc274afe9fce.1675708062.git.pabeni%40redhat.com
patch subject: [PATCH v3 net-next 1/4] net-sysctl: factor out cpumask parsing helper
config: ia64-allyesconfig (https://download.01.org/0day-ci/archive/20230207/202302070311.gE92izdH-lkp@intel.com/config)
compiler: ia64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/f4b9914b6f1b7a7b3e416e1ef67db9ce6ad87f38
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Paolo-Abeni/net-sysctl-factor-out-cpumask-parsing-helper/20230207-023315
git checkout f4b9914b6f1b7a7b3e416e1ef67db9ce6ad87f38
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash net/core/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
>> net/core/sysctl_net_core.c:49:6: warning: no previous prototype for 'dump_cpumask' [-Wmissing-prototypes]
49 | void dump_cpumask(void *buffer, size_t *lenp, loff_t *ppos, struct cpumask *mask)
| ^~~~~~~~~~~~
vim +/dump_cpumask +49 net/core/sysctl_net_core.c
47
48 #if IS_ENABLED(CONFIG_NET_FLOW_LIMIT)
> 49 void dump_cpumask(void *buffer, size_t *lenp, loff_t *ppos, struct cpumask *mask)
50 {
51 char kbuf[128];
52 int len;
53
54 if (*ppos || !*lenp) {
55 *lenp = 0;
56 return;
57 }
58
59 len = min(sizeof(kbuf) - 1, *lenp);
60 len = scnprintf(kbuf, len, "%*pb", cpumask_pr_args(mask));
61 if (!len) {
62 *lenp = 0;
63 return;
64 }
65
66 if (len < *lenp)
67 kbuf[len++] = '\n';
68 memcpy(buffer, kbuf, len);
69 *lenp = len;
70 *ppos += len;
71 }
72 #endif
73
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
Powered by blists - more mailing lists