netdev - Re: [PATCH iproute2-next] bridge: mdb: Remove double space in MDB dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7fb34207-473b-38aa-7184-0bb08fe87d3f@blackwall.org>
Date:   Tue, 7 Feb 2023 00:10:11 +0100
From:   Nikolay Aleksandrov <razor@...ckwall.org>
To:     Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org
Cc:     stephen@...workplumber.org, dsahern@...il.com, mlxsw@...dia.com
Subject: Re: [PATCH iproute2-next] bridge: mdb: Remove double space in MDB
 dump

On 2/6/23 16:21, Ido Schimmel wrote:
> There is an extra space after the "proto" field. Remove it.
> 
> Before:
> 
>   # bridge -d mdb
>   dev br0 port swp1 grp 239.1.1.1 permanent proto static  vid 1
> 
> After:
> 
>   # bridge -d mdb
>   dev br0 port swp1 grp 239.1.1.1 permanent proto static vid 1
> 
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> ---
>   bridge/mdb.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/bridge/mdb.c b/bridge/mdb.c
> index f323cd091fcc..9b5503657178 100644
> --- a/bridge/mdb.c
> +++ b/bridge/mdb.c
> @@ -221,7 +221,7 @@ static void print_mdb_entry(FILE *f, int ifindex, const struct br_mdb_entry *e,
>   			__u8 rtprot = rta_getattr_u8(tb[MDBA_MDB_EATTR_RTPROT]);
>   			SPRINT_BUF(rtb);
>   
> -			print_string(PRINT_ANY, "protocol", " proto %s ",
> +			print_string(PRINT_ANY, "protocol", " proto %s",
>   				     rtnl_rtprot_n2a(rtprot, rtb, sizeof(rtb)));
>   		}
>   	}

Reviewed-by: Nikolay Aleksandrov <razor@...ckwall.org>