netdev - RE: [PATCH net v2 2/2] net: ll_temac: Reset buffer on dma_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 6 Feb 2023 09:59:39 +0000
From:   "Katakam, Harini" <harini.katakam@....com>
To:     Jonas Suhr Christensen <jsc@...raculum.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Michal Simek <michal.simek@...inx.com>,
        Haoyue Xu <xuhaoyue1@...ilicon.com>,
        huangjunxian <huangjunxian6@...ilicon.com>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Yang Yingliang <yangyingliang@...wei.com>,
        Esben Haabendal <esben@...nix.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net v2 2/2] net: ll_temac: Reset buffer on
 dma_map_single() errors

Hi Jonas,

> -----Original Message-----
> From: Jonas Suhr Christensen <jsc@...raculum.org>
> Sent: Monday, February 6, 2023 1:41 AM
> To: netdev@...r.kernel.org
> Cc: jsc@...raculum.org; David S. Miller <davem@...emloft.net>; Eric
> Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>;
> Paolo Abeni <pabeni@...hat.com>; Michal Simek
> <michal.simek@...inx.com>; Katakam, Harini <harini.katakam@....com>;
> Haoyue Xu <xuhaoyue1@...ilicon.com>; huangjunxian
> <huangjunxian6@...ilicon.com>; Christophe JAILLET
> <christophe.jaillet@...adoo.fr>; Yang Yingliang
> <yangyingliang@...wei.com>; Esben Haabendal <esben@...nix.com>;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org
> Subject: [PATCH net v2 2/2] net: ll_temac: Reset buffer on dma_map_single()
> errors
> 
> To avoid later calls to dma_unmap_single() on address'
> that fails to be mapped, free the allocated skb and
> set the pointer of the address to NULL. Eg. when a mapping
> fails temac_dma_bd_release() will try to call dma_unmap_single()
> on that address if the structure is not reset.
> 
> Fixes: d07c849cd2b9 ("net: ll_temac: Add more error handling of
> dma_map_single() calls")
> 
> Signed-off-by: Jonas Suhr Christensen <jsc@...raculum.org>

Thanks for the patch
Reviewed-by: Harini Katakam <harini.katakam@....com>

Regards,
Harini