netdev - Re: [PATCH net v2 1/2] net: ll_temac: Fix DMA resources leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5314e0ba3a728787299ca46a60b0a2da5e8ab23a.camel@redhat.com>
Date:   Tue, 07 Feb 2023 12:27:25 +0100
From:   Paolo Abeni <pabeni@...hat.com>
To:     Jonas Suhr Christensen <jsc@...raculum.org>, netdev@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Michal Simek <michal.simek@...inx.com>,
        Harini Katakam <harini.katakam@....com>,
        Haoyue Xu <xuhaoyue1@...ilicon.com>,
        huangjunxian <huangjunxian6@...ilicon.com>,
        Wang Qing <wangqing@...o.com>,
        Yang Yingliang <yangyingliang@...wei.com>,
        Esben Haabendal <esben@...nix.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v2 1/2] net: ll_temac: Fix DMA resources leak

Hi,

On Sun, 2023-02-05 at 21:11 +0100, Jonas Suhr Christensen wrote:
> Add missing conversion of address when unmapping dma region causing
> unmapping to silently fail. At some point resulting in buffer
> overrun eg. when releasing device.
> 
> Fixes: fdd7454ecb29 ("net: ll_temac: Fix support for little-endian platforms")
> 
> Signed-off-by: Jonas Suhr Christensen <jsc@...raculum.org>

I'm sorry for nit-picking, but you must avoid empty lines in the tag
area. Please post a v2 avoiding the empty line between the Fixes and
sob tags (both here and in the next patch).

You can retain (include in the tag area) the already collected
reviewed-by/acked-by tags.

Thanks,

Paolo