netdev - Re: [PATCH repost] net: fec: Refactor: rename `adapter` to `fep`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bc632bea2357e7cd01a6f130a9413fc7e2933af4.camel@redhat.com>
Date:   Tue, 07 Feb 2023 12:46:48 +0100
From:   Paolo Abeni <pabeni@...hat.com>
To:     Csókás Bence <Csokas.Bence@...lan.hu>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc:     Richard Cochran <richardcochran@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "qiangqing.zhang@....com" <qiangqing.zhang@....com>,
        Andrew Lunn <andrew@...n.ch>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>
Subject: Re: [PATCH repost] net: fec: Refactor: rename `adapter` to `fep`

Hello,

On Mon, 2023-02-06 at 00:03 +0000, Csókás Bence wrote:
> Commit 01b825f reverted a style fix, which renamed
> `struct fec_enet_private *adapter` to `fep` to match
> the rest of the driver. This commit factors out
> that style fix.
> 
> Signed-off-by: Csókás Bence <csokas.bence@...lan.hu>

The patch does not apply cleanly to net-next (nor net, FWIS).

When referencing an existing commit you should use the:

<12 char hash> ("<commit tile>")

format.

More importantly, this kind of refactors are useful if you are going to
touch the relevant code with fixes or new feature in the same series,
otherwise they mainly produces later backport conflicts.

I'm not going to accept this kind of change, sorry.

Paolo