netdev - Re: [PATCH 1/1] net: fec: Don't fail on missing optional phy-reset-gpios

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <21769138.EfDdHjke4D@steina-w>
Date:   Tue, 07 Feb 2023 14:24:22 +0100
From:   Alexander Stein <alexander.stein@...tq-group.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Wei Fang <wei.fang@....com>, Shenwei Wang <shenwei.wang@....com>,
        Clark Wang <xiaoning.wang@....com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, Arnd Bergmann <arnd@...db.de>,
        Andrew Lunn <andrew@...n.ch>,
        NXP Linux Team <linux-imx@....com>, netdev@...r.kernel.org
Subject: Re: [PATCH 1/1] net: fec: Don't fail on missing optional phy-reset-gpios

Am Dienstag, 7. Februar 2023, 07:30:27 CET schrieb Jakub Kicinski:
> On Fri,  3 Feb 2023 14:21:02 +0100 Alexander Stein wrote:
> > The conversion to gpio descriptors accidentally removed the short return
> > if there is no 'phy-reset-gpios' property, leading to the error
> > 
> > fec 30be0000.ethernet: error -ENOENT: failed to get phy-reset-gpios
> > 
> > This is especially the case when the PHY reset GPIO is specified in
> > the PHY node itself.
> > 
> > Fixes: 468ba54bd616 ("fec: convert to gpio descriptor")
> > Signed-off-by: Alexander Stein <alexander.stein@...tq-group.com>
> 
> Fixed around the same time by commit d7b5e5dd669436 right?

Yes, this does the trick as well. Thanks

Best regards
Alexander