netdev - RE: [PATCH net-next 2/3] igc: offload queue max SDU from tc-taprio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 7 Feb 2023 13:38:40 +0000
From:   "Zulkifli, Muhammad Husaini" <muhammad.husaini.zulkifli@...el.com>
To:     Leon Romanovsky <leon@...nel.org>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        Tan Tee Min <tee.min.tan@...ux.intel.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Neftin, Sasha" <sasha.neftin@...el.com>,
        "Naama Meir" <naamax.meir@...ux.intel.com>
Subject: RE: [PATCH net-next 2/3] igc: offload queue max SDU from tc-taprio

Hi Leon,

Sorry for the late reply. Replied inline.

> -----Original Message-----
> From: Leon Romanovsky <leon@...nel.org>
> Sent: Thursday, 26 January, 2023 6:51 PM
> To: Nguyen, Anthony L <anthony.l.nguyen@...el.com>
> Cc: davem@...emloft.net; kuba@...nel.org; pabeni@...hat.com;
> edumazet@...gle.com; Tan Tee Min <tee.min.tan@...ux.intel.com>;
> netdev@...r.kernel.org; Neftin, Sasha <sasha.neftin@...el.com>; Zulkifli,
> Muhammad Husaini <muhammad.husaini.zulkifli@...el.com>; Naama Meir
> <naamax.meir@...ux.intel.com>
> Subject: Re: [PATCH net-next 2/3] igc: offload queue max SDU from tc-taprio
> 
> On Wed, Jan 25, 2023 at 01:27:01PM -0800, Tony Nguyen wrote:
> > From: Tan Tee Min <tee.min.tan@...ux.intel.com>
> >
> > Add support for configuring the max SDU for each Tx queue.
> > If not specified, keep the default.
> >
> > All link speeds have been tested with this implementation.
> > No performance issue observed.
> >
> > How to test:
> >
> > 1) Configure the tc with max-sdu
> >
> > tc qdisc replace dev $IFACE parent root handle 100 taprio \
> >     num_tc 4 \
> >     map 0 1 2 3 3 3 3 3 3 3 3 3 3 3 3 3 \
> >     queues 1@0 1@1 1@2 1@3 \
> >     base-time $BASE \
> >     sched-entry S 0xF 1000000 \
> >     max-sdu 1500 1498 0 0 0 0 0 0 0 0 0 0 0 0 0 0 \
> >     flags 0x2 \
> >     txtime-delay 0
> >
> > 2) Use network statistic to watch the tx queue packet to see if packet
> > able to go out or drop.
> >
> > Signed-off-by: Tan Tee Min <tee.min.tan@...ux.intel.com>
> > Signed-off-by: Muhammad Husaini Zulkifli
> > <muhammad.husaini.zulkifli@...el.com>
> > Tested-by: Naama Meir <naamax.meir@...ux.intel.com>
> > Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>
> > ---
> >  drivers/net/ethernet/intel/igc/igc.h      |  1 +
> >  drivers/net/ethernet/intel/igc/igc_main.c | 44
> > +++++++++++++++++++++++
> >  2 files changed, 45 insertions(+)
> 
> <...>
> 
> > +skb_drop:
> > +	dev_kfree_skb_any(skb);
> > +	skb = NULL;
> 
> Why do you set skb to be NULL?

IMHO, dev_kfree_skb_any(skb) should be enough to free the buffer.
I will remove it on the next submission.

Thanks,
Husaini

> 
> > +
> >  	return NETDEV_TX_OK;
> >  }
> >
> 
> Thanks