[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230207093102-mutt-send-email-mst@kernel.org>
Date: Tue, 7 Feb 2023 09:31:10 -0500
From: "Michael S. Tsirkin" <mst@...hat.com>
To: Lorenzo Bianconi <lorenzo@...nel.org>
Cc: bpf@...r.kernel.org, netdev@...r.kernel.org, ast@...nel.org,
daniel@...earbox.net, andrii@...nel.org, davem@...emloft.net,
kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com,
lorenzo.bianconi@...hat.com, jasowang@...hat.com, hawk@...nel.org,
john.fastabend@...il.com, virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH bpf-next] virtio_net: update xdp_features with xdp
multi-buff
On Tue, Feb 07, 2023 at 10:53:40AM +0100, Lorenzo Bianconi wrote:
> Now virtio-net supports xdp multi-buffer so add it to xdp_features
>
> Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org>
makes sense
Acked-by: Michael S. Tsirkin <mst@...hat.com>
> ---
> drivers/net/virtio_net.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 692dff071782..ddc3dc7ea73c 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -3281,7 +3281,7 @@ static int virtnet_xdp_set(struct net_device *dev, struct bpf_prog *prog,
> virtnet_clear_guest_offloads(vi);
> }
> if (!old_prog)
> - xdp_features_set_redirect_target(dev, false);
> + xdp_features_set_redirect_target(dev, true);
> } else {
> xdp_features_clear_redirect_target(dev);
> vi->xdp_enabled = false;
> @@ -3940,8 +3940,10 @@ static int virtnet_probe(struct virtio_device *vdev)
> INIT_WORK(&vi->config_work, virtnet_config_changed_work);
> spin_lock_init(&vi->refill_lock);
>
> - if (virtio_has_feature(vdev, VIRTIO_NET_F_MRG_RXBUF))
> + if (virtio_has_feature(vdev, VIRTIO_NET_F_MRG_RXBUF)) {
> vi->mergeable_rx_bufs = true;
> + dev->xdp_features |= NETDEV_XDP_ACT_RX_SG;
> + }
>
> if (virtio_has_feature(vi->vdev, VIRTIO_NET_F_NOTF_COAL)) {
> vi->rx_usecs = 0;
> --
> 2.39.1
Powered by blists - more mailing lists