netdev - Re: [PATCH v5 net-next 3/8] sfc: enumerate mports in ef100

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR12MB4202E89F45A1DCD3D7F16879C1DB9@DM6PR12MB4202.namprd12.prod.outlook.com>
Date:   Tue, 7 Feb 2023 15:14:50 +0000
From:   "Lucero Palau, Alejandro" <alejandro.lucero-palau@....com>
To:     Edward Cree <ecree.xilinx@...il.com>,
        "Lucero Palau, Alejandro" <alejandro.lucero-palau@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-net-drivers (AMD-Xilinx)" <linux-net-drivers@....com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "habetsm.xilinx@...il.com" <habetsm.xilinx@...il.com>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "corbet@....net" <corbet@....net>,
        "jiri@...dia.com" <jiri@...dia.com>
Subject: Re: [PATCH v5 net-next 3/8] sfc: enumerate mports in ef100


On 2/6/23 12:38, Edward Cree wrote:
> On 02/02/2023 11:14, alejandro.lucero-palau@....com wrote:
>> From: Alejandro Lucero <alejandro.lucero-palau@....com>
>>
>> MAE ports (mports) are the ports on the EF100 embedded switch such
>> as networking PCIe functions, the physical port, and potentially
>> others.
>>
>> Signed-off-by: Alejandro Lucero <alejandro.lucero-palau@....com>
> ...
>> +struct mae_mport_desc {
>> +	u32 mport_id;
>> +	u32 flags;
>> +	u32 caller_flags; /* enum mae_mport_desc_caller_flags */
>> +	u32 mport_type; /* MAE_MPORT_DESC_MPORT_TYPE_* */
>> +	union {
>> +		u32 port_idx; /* for mport_type == NET_PORT */
>> +		u32 alias_mport_id; /* for mport_type == ALIAS */
>> +		struct { /* for mport_type == VNIC */
>> +			u32 vnic_client_type; /* MAE_MPORT_DESC_VNIC_CLIENT_TYPE_* */
>> +			u32 interface_idx;
>> +			u16 pf_idx;
>> +			u16 vf_idx;
>> +		};
>> +	};
>> +	struct rhash_head linkage;
>> +	struct efx_rep *efv;
> Looks like this isn't used or populated anywhere, so probably
>   shouldn't be added yet.


OK.

Thanks

> Apart from that, LGTM.