netdev - Re: [PATCH net-next 3/4] s390/qeth: Convert sysfs sprintf to sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y+JwP3HuNakOeifm@corigine.com>
Date:   Tue, 7 Feb 2023 16:37:35 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Alexandra Winter <wintera@...ux.ibm.com>
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        linux-s390@...r.kernel.org, Heiko Carstens <hca@...ux.ibm.com>,
        Thorsten Winkler <twinkler@...ux.ibm.com>,
        Jules Irenge <jbi.octave@...il.com>,
        Joe Perches <joe@...ches.com>
Subject: Re: [PATCH net-next 3/4] s390/qeth: Convert sysfs sprintf to
 sysfs_emit

On Mon, Feb 06, 2023 at 06:27:53PM +0100, Alexandra Winter wrote:
> From: Thorsten Winkler <twinkler@...ux.ibm.com>
> 
> Following the advice of the Documentation/filesystems/sysfs.rst.
> All sysfs related show()-functions should only use sysfs_emit() or
> sysfs_emit_at() when formatting the value to be returned to user space.
> 
> Reported-by: Jules Irenge <jbi.octave@...il.com>
> Reported-by: Joe Perches <joe@...ches.com>
> Reviewed-by: Alexandra Winkler <wintera@...ux.ibm.com>

s/Winkler/Winter/ ?

> Signed-off-by: Thorsten Winkler <twinkler@...ux.ibm.com>
> Signed-off-by: Alexandra Winter <wintera@...ux.ibm.com>

Code changes look good to me.