netdev - Re: [PATCH v2 net-next 0/4] net: core: use a dedicated kmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b9eeaeb896fe5913e411d1bf90ebbec2a2ab0e31.camel@gmail.com>
Date:   Tue, 07 Feb 2023 08:58:04 -0800
From:   Alexander H Duyck <alexander.duyck@...il.com>
To:     Eric Dumazet <edumazet@...gle.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        Soheil Hassas Yeganeh <soheil@...gle.com>
Subject: Re: [PATCH v2 net-next 0/4] net: core: use a dedicated kmem_cache
 for skb head allocs

On Mon, 2023-02-06 at 17:30 +0000, Eric Dumazet wrote:
> Our profile data show that using kmalloc(non_const_size)/kfree(ptr)
> has a certain cost, because kfree(ptr) has to pull a 'struct page'
> in cpu caches.
> 
> Using a dedicated kmem_cache for TCP skb->head allocations makes
> a difference, both in cpu cycles and memory savings.
> 
> This kmem_cache could also be used for GRO skb allocations,
> this is left as a future exercise.
> 
> v2: addressed compile error with CONFIG_SLOB=y (kernel bots)
>     Changed comment (Jakub)
> 
> Eric Dumazet (4):
>   net: add SKB_HEAD_ALIGN() helper
>   net: remove osize variable in __alloc_skb()
>   net: factorize code in kmalloc_reserve()
>   net: add dedicated kmem_cache for typical/small skb->head
> 
>  include/linux/skbuff.h |   8 +++
>  net/core/skbuff.c      | 115 +++++++++++++++++++++++++++++------------
>  2 files changed, 90 insertions(+), 33 deletions(-)
> 

Looks good to me.

Reviewed-by: Alexander Duyck <alexanderduyck@...com>