netdev - Re: [PATCH net-next] devlink: Fix memleak in health diagnose callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y+HyyZ7KmAWQGzbC@corigine.com>
Date:   Tue, 7 Feb 2023 07:42:17 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Moshe Shemesh <moshe@...dia.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        Jiri Pirko <jiri@...dia.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] devlink: Fix memleak in health diagnose callback

On Mon, Feb 06, 2023 at 05:56:16PM +0200, Moshe Shemesh wrote:
> The callback devlink_nl_cmd_health_reporter_diagnose_doit() miss
> devlink_fmsg_free(), which leads to memory leak.
> 
> Fix it by adding devlink_fmsg_free().
> 
> Fixes: e994a75fb7f9 ("devlink: remove reporter reference counting")
> Signed-off-by: Moshe Shemesh <moshe@...dia.com>
> Reviewed-by: Jiri Pirko <jiri@...dia.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>