netdev - Re: [PATCH iproute2-next 3/3] man: man8: bridge: Describe mcast_max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87sffhdcsm.fsf@nvidia.com>
Date:   Tue, 7 Feb 2023 10:49:32 +0100
From:   Petr Machata <petrm@...dia.com>
To:     Nikolay Aleksandrov <razor@...ckwall.org>
CC:     Petr Machata <petrm@...dia.com>, <netdev@...r.kernel.org>,
        <dsahern@...il.com>, <stephen@...workplumber.org>,
        Ido Schimmel <idosch@...dia.com>
Subject: Re: [PATCH iproute2-next 3/3] man: man8: bridge: Describe
 mcast_max_groups


Nikolay Aleksandrov <razor@...ckwall.org> writes:

> On 2/6/23 19:50, Petr Machata wrote:
>> Add documentation for per-port and port-port-vlan option mcast_max_groups.
>> Signed-off-by: Petr Machata <petrm@...dia.com>
>> ---
>>   man/man8/bridge.8 | 22 ++++++++++++++++++++++
>>   1 file changed, 22 insertions(+)
>> diff --git a/man/man8/bridge.8 b/man/man8/bridge.8
>> index f73e538a3536..7075eab283fa 100644
>> --- a/man/man8/bridge.8
>> +++ b/man/man8/bridge.8
>> @@ -47,6 +47,8 @@ bridge \- show / manipulate bridge addresses and devices
>>   .BR hwmode " { " vepa " | " veb " } ] [ "
>>   .BR bcast_flood " { " on " | " off " } ] [ "
>>   .BR mcast_flood " { " on " | " off " } ] [ "
>> +.BR mcast_max_groups
>> +.IR MAX_GROUPS " ] ["
>>   .BR mcast_router
>>   .IR MULTICAST_ROUTER " ] ["
>>   .BR mcast_to_unicast " { " on " | " off " } ] [ "
>> @@ -169,6 +171,8 @@ bridge \- show / manipulate bridge addresses and devices
>>   .IR VID " [ "
>>   .B state
>>   .IR STP_STATE " ] [ "
>> +.B mcast_max_groups
>> +.IR MAX_GROUPS " ] [ "
>>   .B mcast_router
>>   .IR MULTICAST_ROUTER " ]"
>>   @@ -517,6 +521,15 @@ By default this flag is on.
>>   Controls whether multicast traffic for which there is no MDB entry will be
>>   flooded towards this given port. By default this flag is on.
>>   +.TP
>> +.BI mcast_max_groups " MAX_GROUPS "
>> +Sets the maximum number of MDB entries that can be registered for a given
>> +port. Attempts to register more MDB entries at the port than this limit
>> +allows will be rejected, whether they are done through netlink (e.g. the
>> +\fBbridge\fR tool), or IGMP or MLD membership reports. Setting a limit to 0
>> +has the effect of disabling the limit. See also the \fBip link\fR option
>> +\fBmcast_hash_max\fR.
>> +
>
> I'd add that the default is 0 (no limit), otherwise looks good to me.

OK.