netdev - Re: [PATCH net-next v5 03/23] net: phy: micrel: add ksz9477_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y+GfRU1uAxnAgNQY@lunn.ch>
Date:   Tue, 7 Feb 2023 01:45:57 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Oleksij Rempel <o.rempel@...gutronix.de>
Cc:     Woojung Huh <woojung.huh@...rochip.com>,
        UNGLinuxDriver@...rochip.com,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Wei Fang <wei.fang@....com>,
        Heiner Kallweit <hkallweit1@...il.com>, kernel@...gutronix.de,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        Arun.Ramadoss@...rochip.com, intel-wired-lan@...ts.osuosl.org
Subject: Re: [PATCH net-next v5 03/23] net: phy: micrel: add
 ksz9477_get_features()

On Mon, Feb 06, 2023 at 02:50:30PM +0100, Oleksij Rempel wrote:
> KSZ8563R, which has same PHYID as KSZ9477 family, will change "EEE control
> and capability 1" (Register 3.20) content depending on configuration of
> "EEE advertisement 1" (Register 7.60). Changes on the 7.60 will affect
> 3.20 register.
> 
> So, instead of depending on register 3.20, driver should set supported_eee.
> 
> Proper supported_eee configuration is needed to make use of generic
> PHY c45 set/get_eee functions provided by next patches.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew