netdev - Re: [PATCH] PCI: Add ACS quirk for Wangxun NICs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y+NbV5rKVV3zBx7A@corigine.com>
Date:   Wed, 8 Feb 2023 09:20:39 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     "mengyuanlou@...-swift.com" <mengyuanlou@...-swift.com>
Cc:     netdev@...r.kernel.org, linux-pci@...r.kernel.org,
        helgaas@...nel.org
Subject: Re: [PATCH] PCI: Add ACS quirk for Wangxun NICs

On Wed, Feb 08, 2023 at 10:16:13AM +0800, mengyuanlou@...-swift.com wrote:
> 
> 
> > 2023年2月8日 01:38，Simon Horman <simon.horman@...igine.com> 写道：
> > 
> > On Tue, Feb 07, 2023 at 06:24:19PM +0800, Mengyuan Lou wrote:
> >> Wangxun has verified there is no peer-to-peer between functions for the
> >> below selection of SFxxx, RP1000 and RP2000 NICS.
> >> They may be multi-function device, but the hardware does not advertise
> >> ACS capability.
> >> 
> >> Add an ACS quirk for these devices so the functions can be in
> >> independent IOMMU groups.
> >> 
> >> Signed-off-by: Mengyuan Lou <mengyuanlou@...-swift.com>
> > 
> > ...
> > 
> >> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> >> index b362d90eb9b0..bc8f484cdcf3 100644
> >> --- a/include/linux/pci_ids.h
> >> +++ b/include/linux/pci_ids.h
> >> @@ -3012,6 +3012,8 @@
> >> #define PCI_DEVICE_ID_INTEL_VMD_9A0B 0x9a0b
> >> #define PCI_DEVICE_ID_INTEL_S21152BB 0xb152
> >> 
> >> +#define PCI_VENDOR_ID_WANGXUN 0x8088
> >> +
> > 
> > nit: this is already present in drivers/net/ethernet/wangxun/libwx/wx_type.h
> >     perhaps it can be removed from there as a follow-up ?
> It will be removed in a later patch.

Perfect, thanks.

> >> #define PCI_VENDOR_ID_SCALEMP 0x8686
> >> #define PCI_DEVICE_ID_SCALEMP_VSMP_CTL 0x1010