netdev - Re: [PATCH net-next v2 1/3] string_helpers: Move string_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VcQmL4REigquKZwuQmOovcOhjQ8A+Ri8U0D5YEL4v83cQ@mail.gmail.com>
Date:   Wed, 8 Feb 2023 13:15:29 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Xin Long <lucien.xin@...il.com>, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, dev@...nvswitch.org,
        tipc-discussion@...ts.sourceforge.net,
        Andy Shevchenko <andy@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Pravin B Shelar <pshelar@....org>,
        Jon Maloy <jmaloy@...hat.com>,
        Ying Xue <ying.xue@...driver.com>,
        Simon Horman <simon.horman@...igine.com>
Subject: Re: [PATCH net-next v2 1/3] string_helpers: Move string_is_valid() to
 the header

On Wed, Feb 8, 2023 at 6:29 AM Jakub Kicinski <kuba@...nel.org> wrote:
> On Mon,  6 Feb 2023 18:13:12 +0200 Andy Shevchenko wrote:
> > +static inline bool string_is_valid(const char *s, int len)
> > +{
> > +     return memchr(s, '\0', len) ? true : false;
> > +}
>
> I was tempted to suggest adding a kdoc, but perhaps the function
> doesn't have an obvious enough name? Maybe we should call the helper
> string_is_terminated(), instead?

Sure.

-- 
With Best Regards,
Andy Shevchenko