netdev - Re: [PATCH] net: stmmac: get phydev->interface from mac for mdio phy init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y+OjvfOvqz0s8qDr@lunn.ch>
Date:   Wed, 8 Feb 2023 14:29:33 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Simon Horman <simon.horman@...igine.com>
Cc:     Guan Wentao <guanwentao@...ontech.com>, peppe.cavallaro@...com,
        alexandre.torgue@...s.st.com, joabreu@...opsys.com,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, mcoquelin.stm32@...il.com,
        netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] net: stmmac: get phydev->interface from mac for mdio phy
 init

On Wed, Feb 08, 2023 at 02:11:52PM +0100, Simon Horman wrote:
> On Wed, Feb 08, 2023 at 08:40:25PM +0800, Guan Wentao wrote:
> > The phy->interface from mdiobus_get_phy is default from phy_device_create.
> > In some phy devices like at803x, use phy->interface to init rgmii delay.
> > Use plat->phy_interface to init if know from stmmac_probe_config_dt.
> > 
> > Fixes: 74371272f97f ("net: stmmac: Convert to phylink and remove phylib logic")
> > Signed-off-by: Guan Wentao <guanwentao@...ontech.com>
> > ---
> 
> This is v2 of this patch, so let me make some comments about that.
> 
> * Firstly, unless asked to repost by a reviewer/maintainer,
>   it's generally bad practice to post a patch(set) more than once within 24h.

Hi Guan

I just showed you why there is this 24 hour rule by replying to your
first version...

      Andrew