netdev - Re: [PATCH -next] net: bridge: clean up one inconsistent indenting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y+OnVfu/3ot3Rk7f@corigine.com>
Date:   Wed, 8 Feb 2023 14:44:53 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Nikolay Aleksandrov <razor@...ckwall.org>
Cc:     Yang Li <yang.lee@...ux.alibaba.com>, davem@...emloft.net,
        kuba@...nel.org, edumazet@...gle.com, roopa@...dia.com,
        pabeni@...hat.com, bridge@...ts.linux-foundation.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] net: bridge: clean up one inconsistent indenting

On Wed, Feb 08, 2023 at 02:31:39PM +0100, Nikolay Aleksandrov wrote:
> On 2/8/23 15:30, Nikolay Aleksandrov wrote:
> > On 2/8/23 15:04, Simon Horman wrote:
> > > On Wed, Feb 08, 2023 at 08:56:26AM +0800, Yang Li wrote:
> > > > ./net/bridge/br_netlink_tunnel.c:317:4-27: code aligned with
> > > > following code on line 318
> > > > 
> > > > Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> > > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3977
> > > > Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> > > 
> > > As you may need to respin this:
> > > 
> > > Assuming this is targeting net-next, which seems likely to me,
> > > the subject should denote that. Something like this:
> > > 
> > > [PATCH net-next] net: bridge: clean up one inconsistent indenting
> > > 
> > > > ---
> > > >   net/bridge/br_netlink_tunnel.c | 2 +-
> > > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/net/bridge/br_netlink_tunnel.c
> > > > b/net/bridge/br_netlink_tunnel.c
> > > > index 17abf092f7ca..eff949bfdd83 100644
> > > > --- a/net/bridge/br_netlink_tunnel.c
> > > > +++ b/net/bridge/br_netlink_tunnel.c
> > > > @@ -315,7 +315,7 @@ int br_process_vlan_tunnel_info(const struct
> > > > net_bridge *br,
> > > >               if (curr_change)
> > > >                   *changed = curr_change;
> > > > -             __vlan_tunnel_handle_range(p, &v_start, &v_end, v,
> > > > +            __vlan_tunnel_handle_range(p, &v_start, &v_end, v,
> > > >                               curr_change);
> > > 
> > > I think you also need to adjust the line immediately above.
> > 
> > You meant below, right? :) i.e. "curr_change)", that seems to get
> > misaligned after the change and needs to be adjusted as well.
> > 
> 
> Oh I need coffee, I somehow was thinking about the line being changed
> instead of literally the line above your statement. :))

No problem. We are talking about the same line :)

> Anyway, ack.