[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <DM6PR12MB4202FE90A833282B28053DF7C1D89@DM6PR12MB4202.namprd12.prod.outlook.com>
Date: Wed, 8 Feb 2023 15:24:39 +0000
From: "Lucero Palau, Alejandro" <alejandro.lucero-palau@....com>
To: Jiri Pirko <jiri@...nulli.us>,
"Lucero Palau, Alejandro" <alejandro.lucero-palau@....com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-net-drivers (AMD-Xilinx)" <linux-net-drivers@....com>,
"davem@...emloft.net" <davem@...emloft.net>,
"kuba@...nel.org" <kuba@...nel.org>,
"pabeni@...hat.com" <pabeni@...hat.com>,
"edumazet@...gle.com" <edumazet@...gle.com>,
"habetsm.xilinx@...il.com" <habetsm.xilinx@...il.com>,
"ecree.xilinx@...il.com" <ecree.xilinx@...il.com>,
"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
"corbet@....net" <corbet@....net>,
"jiri@...dia.com" <jiri@...dia.com>
Subject: Re: [PATCH v6 net-next 2/8] sfc: add devlink info support for ef100
On 2/8/23 14:38, Jiri Pirko wrote:
> Wed, Feb 08, 2023 at 03:25:13PM CET, alejandro.lucero-palau@....com wrote:
>> From: Alejandro Lucero <alejandro.lucero-palau@....com>
> [..]
>
>
>> +static int efx_devlink_info_get(struct devlink *devlink,
>> + struct devlink_info_req *req,
>> + struct netlink_ext_ack *extack)
>> +{
>> + struct efx_devlink *devlink_private = devlink_priv(devlink);
>> + struct efx_nic *efx = devlink_private->efx;
>> + int rc;
>> +
>> + /* Several different MCDI commands are used. We report first error
>> + * through extack along with total number of errors. Specific error
>> + * information via system messages.
> I think you forgot to remove this comment.
>
> With this nit fixed, free free to add:
> Reviewed-by: Jiri Pirko <jiri@...dia.com>
>
I'll do.
Thanks
>
>> + */
>> + rc = efx_devlink_info_board_cfg(efx, req);
>> + if (rc) {
>> + NL_SET_ERR_MSG_MOD(extack, "Getting board info failed");
>> + return rc;
>> + }
>> + rc = efx_devlink_info_stored_versions(efx, req);
>> + if (rc) {
>> + NL_SET_ERR_MSG_MOD(extack, "Getting stored versions failed");
>> + return rc;
>> + }
>> + rc = efx_devlink_info_running_versions(efx, req);
>> + if (rc) {
>> + NL_SET_ERR_MSG_MOD(extack, "Getting running versions failed");
>> + return rc;
>> + }
>> +
>> + return 0;
>> +}
>> +#endif
> [..]
>
Powered by blists - more mailing lists