[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c33e26364b18039e3632218d8e2a76f3b6a08577.camel@gmail.com>
Date: Wed, 08 Feb 2023 07:41:14 -0800
From: Alexander H Duyck <alexander.duyck@...il.com>
To: Jason Xing <kerneljasonxing@...il.com>, jesse.brandeburg@...el.com,
anthony.l.nguyen@...el.com, davem@...emloft.net,
edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
richardcochran@...il.com, ast@...nel.org, daniel@...earbox.net,
hawk@...nel.org, john.fastabend@...il.com,
alexandr.lobakin@...el.com, maciej.fijalkowski@...el.com
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, bpf@...r.kernel.org,
Jason Xing <kernelxing@...cent.com>
Subject: Re: [PATCH net v2 2/3] i40e: add double of VLAN header when
computing the max MTU
On Wed, 2023-02-08 at 10:43 +0800, Jason Xing wrote:
> From: Jason Xing <kernelxing@...cent.com>
>
> Include the second VLAN HLEN into account when computing the maximum
> MTU size as other drivers do.
>
> Fixes: 0c8493d90b6b ("i40e: add XDP support for pass and drop actions")
> Signed-off-by: Jason Xing <kernelxing@...cent.com>
> ---
> v2: drop the duplicate definition
> ---
> drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
> index 53d0083e35da..d039928f3646 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
> @@ -2921,7 +2921,7 @@ static int i40e_change_mtu(struct net_device *netdev, int new_mtu)
> struct i40e_pf *pf = vsi->back;
>
> if (i40e_enabled_xdp_vsi(vsi)) {
> - int frame_size = new_mtu + ETH_HLEN + ETH_FCS_LEN + VLAN_HLEN;
> + int frame_size = new_mtu + I40E_PACKET_HDR_PAD;
>
> if (frame_size > i40e_max_xdp_frame_size(vsi))
> return -EINVAL;
Looks good to me.
Reviewed-by: Alexander Duyck <alexanderduyck@...com>
Powered by blists - more mailing lists