[<prev] [next>] [day] [month] [year] [list]
Message-ID: <Y+PJADTk88OTPCx1@smile.fi.intel.com>
Date: Wed, 8 Feb 2023 18:08:32 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@...adcom.com>
Cc: Pawel Chmielewski <pawel.chmielewski@...el.com>,
yury.norov@...il.com, Jonathan.Cameron@...wei.com,
baohua@...nel.org, bristot@...hat.com, bsegall@...gle.com,
davem@...emloft.net, dietmar.eggemann@....com, gal@...dia.com,
gregkh@...uxfoundation.org, hca@...ux.ibm.com,
jacob.e.keller@...el.com, jesse.brandeburg@...el.com,
jgg@...dia.com, juri.lelli@...hat.com, kuba@...nel.org,
leonro@...dia.com, linux-crypto@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org,
linux@...musvillemoes.dk, mgorman@...e.de, mingo@...hat.com,
netdev@...r.kernel.org, peter@...jl.ca, peterz@...radead.org,
rostedt@...dmis.org, saeedm@...dia.com, tariqt@...dia.com,
tony.luck@...el.com, torvalds@...ux-foundation.org,
ttoukan.linux@...il.com, vincent.guittot@...aro.org,
vschneid@...hat.com
Subject: Re: [PATCH 1/1] ice: Change assigning method of the CPU affinity
masks
On Wed, Feb 08, 2023 at 09:18:14PM +0530, Kalesh Anakkur Purayil wrote:
> On Wed, Feb 8, 2023 at 9:11 PM Pawel Chmielewski <
> pawel.chmielewski@...el.com> wrote:
...
> > + u16 v_idx, cpu = 0;
> >
> [Kalesh]: if you initialize v_idx to 0 here, you can avoid the assignment
> below
I would avoid doing this.
The problem is that it will become harder to maintain and more error prone
during development.
So, please leave as is.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists