netdev - Re: [PATCH net] selftests: Fix failing VXLAN VNI filtering test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <93f2dd4aa0455d2ff30da8bbaa08c779dbc0b242.camel@gmail.com>
Date:   Wed, 08 Feb 2023 09:13:20 -0800
From:   Alexander H Duyck <alexander.duyck@...il.com>
To:     Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        edumazet@...gle.com, roopa@...dia.com
Subject: Re: [PATCH net] selftests: Fix failing VXLAN VNI filtering test

On Tue, 2023-02-07 at 16:18 +0200, Ido Schimmel wrote:
> iproute2 does not recognize the "group6" and "remote6" keywords. Fix by
> using "group" and "remote" instead.
> 
> Before:
> 
>  # ./test_vxlan_vnifiltering.sh
>  [...]
>  Tests passed:  25
>  Tests failed:   2
> 
> After:
> 
>  # ./test_vxlan_vnifiltering.sh
>  [...]
>  Tests passed:  27
>  Tests failed:   0
> 
> Fixes: 3edf5f66c12a ("selftests: add new tests for vxlan vnifiltering")
> Signed-off-by: Ido Schimmel <idosch@...dia.com>

Looks good to me. From what I can tell the group6/remote6 stuff does
apply to the ip link VXLAN stuff but doesn't apply the VNI stuff for
the bridge. I'm suspecting that may be where they picked it up from.

Reviewed-by: Alexander Duyck <alexanderduyck@...com>