netdev - Re: [PATCH net-next 3/4] s390/qeth: Convert sysfs sprintf to sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d0f3a634-6c47-2b5d-0c20-8ef1e3a5a004@linux.ibm.com>
Date:   Wed, 8 Feb 2023 19:30:19 +0100
From:   Alexandra Winter <wintera@...ux.ibm.com>
To:     Joe Perches <joe@...ches.com>, David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, linux-s390@...r.kernel.org,
        Heiko Carstens <hca@...ux.ibm.com>,
        Thorsten Winkler <twinkler@...ux.ibm.com>,
        Jules Irenge <jbi.octave@...il.com>
Subject: Re: [PATCH net-next 3/4] s390/qeth: Convert sysfs sprintf to
 sysfs_emit



On 07.02.23 17:06, Joe Perches wrote:
> On Mon, 2023-02-06 at 18:27 +0100, Alexandra Winter wrote:
>> From: Thorsten Winkler <twinkler@...ux.ibm.com>
...
> 
> One of the intended uses of sysfs_emit is to not require the
> knowlege of buf as PAGE_SIZE so it could possibly be
> extended/changed.
> 
> So perhaps the use of entry_len is useless and the PAGE_SIZE use
> above should be removed.
> 

Thanks a lot for pointing that out. Will send a v2 tomorrow.

> The below though could emit a partial line, dunno if that's a
> good thing or not but sysfs is not supposed to emit multiple
> lines anyway.

Agree, this may not be the best usage of sysfs.
But we don't want to change existing behaviour with this patch.