netdev - Re: [PATCH net] net: bgmac: fix BCM5358 support by setting correct flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <03ba5b04-fcdc-8eba-5d7b-b1739965d0a8@gmail.com>
Date:   Wed, 8 Feb 2023 10:40:31 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Rafał Miłecki <zajec5@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        bcm-kernel-feedback-list@...adcom.com
Cc:     Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        Rafał Miłecki <rafal@...ecki.pl>,
        Jon Mason <jdmason@...zu.us>
Subject: Re: [PATCH net] net: bgmac: fix BCM5358 support by setting correct
 flags

On 2/8/23 01:16, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@...ecki.pl>
> 
> Code blocks handling BCMA_CHIP_ID_BCM5357 and BCMA_CHIP_ID_BCM53572 were
> incorrectly unified. Chip package values are not unique and cannot be
> checked independently. They are meaningful only in a context of a given
> chip.
> 
> Packages BCM5358 and BCM47188 share the same value but then belong to
> different chips. Code unification resulted in treating BCM5358 as
> BCM47188 and broke its initialization.
> 
> Link: https://github.com/openwrt/openwrt/issues/8278
> Fixes: cb1b0f90acfe ("net: ethernet: bgmac: unify code of the same family")
> Cc: Jon Mason <jdmason@...zu.us>
> Signed-off-by: Rafał Miłecki <rafal@...ecki.pl>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian