netdev - Re: [PATCH 1/2] iwl4965: Add missing check for create_singlethread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230208201658.GA1435569@wp.pl>
Date:   Wed, 8 Feb 2023 21:16:58 +0100
From:   Stanislaw Gruszka <stf_xl@...pl>
To:     Jiasheng Jiang <jiasheng@...as.ac.cn>
Cc:     kvalo@...nel.org, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] iwl4965: Add missing check for
 create_singlethread_workqueue

On Wed, Feb 08, 2023 at 02:30:31PM +0800, Jiasheng Jiang wrote:
> Add the check for the return value of the create_singlethread_workqueue
> in order to avoid NULL pointer dereference.
> 
> Fixes: b481de9ca074 ("[IWLWIFI]: add iwlwifi wireless drivers")
> Signed-off-by: Jiasheng Jiang <jiasheng@...as.ac.cn>
Acked-by: Stanislaw Gruszka <stf_xl@...pl>

>  static void
> @@ -6618,7 +6622,11 @@ il4965_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>  		goto out_disable_msi;
>  	}
>  
> -	il4965_setup_deferred_work(il);
> +	err = il4965_setup_deferred_work(il);
> +	if (err) {
> +		goto out_free_irq;
> +	}

{} not needded.