netdev - Re: [PATCH net-next] nfp: flower: add check for flower VF netdevs for get/set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 08 Feb 2023 04:30:19 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Simon Horman <simon.horman@...igine.com>
Cc:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        netdev@...r.kernel.org, oss-drivers@...igine.com,
        james.hershaw@...igine.com, louis.peens@...igine.com
Subject: Re: [PATCH net-next] nfp: flower: add check for flower VF netdevs for
 get/set_eeprom

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@...nel.org>:

On Mon,  6 Feb 2023 16:48:36 +0100 you wrote:
> From: James Hershaw <james.hershaw@...igine.com>
> 
> Move the nfp_net_get_port_mac_by_hwinfo() check to ahead in the
> get/set_eeprom() functions to in order to check for a VF netdev, which
> this function does not support.
> 
> It is debatable if this is a fix or an enhancement, and we have chosen
> to go for the latter. It does address a problem introduced by
> commit 74b4f1739d4e ("nfp: flower: change get/set_eeprom logic and enable for flower reps").
> However, the ethtool->len == 0 check avoids the problem manifesting as a
> run-time bug (NULL pointer dereference of app).
> 
> [...]

Here is the summary with links:
  - [net-next] nfp: flower: add check for flower VF netdevs for get/set_eeprom
    https://git.kernel.org/netdev/net-next/c/f817554786dd

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html