[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y+REjDdjHkv4g45o@lunn.ch>
Date: Thu, 9 Feb 2023 01:55:40 +0100
From: Andrew Lunn <andrew@...n.ch>
To: "A. Sverdlin" <alexander.sverdlin@...mens.com>
Cc: Wei Fang <wei.fang@....com>, Shenwei Wang <shenwei.wang@....com>,
Clark Wang <xiaoning.wang@....com>,
NXP Linux Team <linux-imx@....com>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: fec: Defer probe if other FEC has deferred MDIO
> - if ((fep->quirks & FEC_QUIRK_SINGLE_MDIO) && fep->dev_id > 0) {
> + if (fep->quirks & FEC_QUIRK_SINGLE_MDIO) {
> /* fec1 uses fec0 mii_bus */
> if (mii_cnt && fec0_mii_bus) {
> fep->mii_bus = fec0_mii_bus;
> mii_cnt++;
> return 0;
> }
> - return -ENOENT;
Could you not add an else clause here? return -EPROBE_DEFFER?
Basically, if fec0 has not probed, deffer the probing of fec1?
Andrew
Powered by blists - more mailing lists