netdev - RE: [PATCH net-next 4/4] net: renesas: rswitch: Improve TX timestamp accuracy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <TYBPR01MB53417BD8EF0FD35376897B51D8D99@TYBPR01MB5341.jpnprd01.prod.outlook.com>
Date:   Thu, 9 Feb 2023 01:06:37 +0000
From:   Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>
Subject: RE: [PATCH net-next 4/4] net: renesas: rswitch: Improve TX timestamp
 accuracy

Hi Jakub,

> From: Jakub Kicinski, Sent: Thursday, February 9, 2023 9:07 AM
> 
> On Wed,  8 Feb 2023 16:34:45 +0900 Yoshihiro Shimoda wrote:
> > In the previous code, TX timestamp accuracy was bad because the irq
> > handler got the timestamp from the timestamp register at that time.
> >
> > This hardware has "Timestamp capture" feature which can store
> > each TX timestamp into the timestamp descriptors. To improve
> > TX timestamp accuracy, implement timestamp descriptors' handling.
> 
> 2 new sparse warnings here:
> 
> drivers/net/ethernet/renesas/rswitch.c:917:24: warning: restricted __le32 degrades to integer
> drivers/net/ethernet/renesas/rswitch.c:918:23: warning: restricted __le32 degrades to integer

Thank you for your review!
I'll fix the warnings on v3 patch.

Best regards,
Yoshihiro Shimoda