[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e9772188-2b52-d7f4-0540-9e9402155285@nvidia.com>
Date: Thu, 9 Feb 2023 16:59:24 +0530
From: Dipen Patel <dipenp@...dia.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Arnd Bergmann <arnd@...db.de>,
Linus Walleij <linus.walleij@...aro.org>,
Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
Tony Lindgren <tony@...mide.com>,
Thomas Gleixner <tglx@...utronix.de>,
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Geert Uytterhoeven <geert@...ux-m68k.org>,
Michael Ellerman <mpe@...erman.id.au>,
Christophe Leroy <christophe.leroy@...roup.eu>,
Vincenzo Palazzo <vincenzopalazzodev@...il.com>,
Devarsh Thakkar <devarsht@...com>,
Michael Walle <michael@...le.cc>,
Dmitry Torokhov <dmitry.torokhov@...il.com>,
Thierry Reding <treding@...dia.com>,
Stefan Schmidt <stefan@...enfreihafen.org>,
Miquel Raynal <miquel.raynal@...tlin.com>,
Lee Jones <lee@...nel.org>, linux-gpio@...r.kernel.org,
linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-doc-tw-discuss@...ts.sourceforge.net,
linux-arm-kernel@...ts.infradead.org, linux-omap@...r.kernel.org,
linux-samsung-soc@...r.kernel.org, linux-m68k@...ts.linux-m68k.org,
linuxppc-dev@...ts.ozlabs.org, linux-sh@...r.kernel.org,
linux-acpi@...r.kernel.org, linux-tegra@...r.kernel.org,
linux-input@...r.kernel.org, linux-media@...r.kernel.org,
linux-wpan@...r.kernel.org, netdev@...r.kernel.org,
linux-wireless@...r.kernel.org,
brcm80211-dev-list.pdl@...adcom.com,
SHA-cyfmac-dev-list@...ineon.com, linux-arch@...r.kernel.org,
devicetree@...r.kernel.org
Cc: Bartosz Golaszewski <brgl@...ev.pl>,
Jonathan Corbet <corbet@....net>, Alex Shi <alexs@...nel.org>,
Yanteng Si <siyanteng@...ngson.cn>,
Hu Haowen <src.res@...il.cn>,
Russell King <linux@...linux.org.uk>,
Aaro Koskinen <aaro.koskinen@....fi>,
Janusz Krzysztofik <jmkrzyszt@...il.com>,
Andrew Lunn <andrew@...n.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
Gregory Clement <gregory.clement@...tlin.com>,
Alim Akhtar <alim.akhtar@...sung.com>,
Nicholas Piggin <npiggin@...il.com>,
Yoshinori Sato <ysato@...rs.sourceforge.jp>,
Rich Felker <dalias@...c.org>,
Mun Yew Tham <mun.yew.tham@...el.com>,
Keerthy <j-keerthy@...com>,
Mika Westerberg <mika.westerberg@...ux.intel.com>,
Thierry Reding <thierry.reding@...il.com>,
Jonathan Hunter <jonathanh@...dia.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Alexander Aring <alex.aring@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Arend van Spriel <aspriel@...il.com>,
Franky Lin <franky.lin@...adcom.com>,
Hante Meuleman <hante.meuleman@...adcom.com>,
Kalle Valo <kvalo@...nel.org>, Qiang Zhao <qiang.zhao@....com>,
Li Yang <leoyang.li@....com>, Rob Herring <robh+dt@...nel.org>,
Frank Rowand <frowand.list@...il.com>
Subject: Re: [PATCH v4 03/18] hte: tegra-194: Use proper includes
On 2/8/23 11:03 PM, Andy Shevchenko wrote:
> From: Linus Walleij <linus.walleij@...aro.org>
>
> The test driver uses the gpiod consumer API so include the right
> <linux/gpio/consumer.h> header. This may cause a problem with
> struct of_device_id being implcitly pulled in by the legacy
> header <linux/gpio.h> so include <linux/mod_devicetable.h>
> explicitly as well.
>
> While at it, drop explicit moduleparam.h (it's included with module.h)
> and sort the headers.
>
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
> drivers/hte/hte-tegra194-test.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/hte/hte-tegra194-test.c b/drivers/hte/hte-tegra194-test.c
> index 5d776a185bd6..358d4a10c6a1 100644
> --- a/drivers/hte/hte-tegra194-test.c
> +++ b/drivers/hte/hte-tegra194-test.c
> @@ -6,14 +6,14 @@
> */
>
> #include <linux/err.h>
> -#include <linux/module.h>
> -#include <linux/moduleparam.h>
> +#include <linux/gpio/consumer.h>
> +#include <linux/hte.h>
> #include <linux/interrupt.h>
> -#include <linux/gpio.h>
> -#include <linux/timer.h>
> +#include <linux/mod_devicetable.h>
> +#include <linux/module.h>
> #include <linux/platform_device.h>
> +#include <linux/timer.h>
> #include <linux/workqueue.h>
> -#include <linux/hte.h>
>
> /*
> * This sample HTE GPIO test driver demonstrates HTE API usage by enabling
Acked-by: Dipen Patel <dipenp@...dia.com>
Powered by blists - more mailing lists