netdev - Re: [PATCH v2 net-next v2] nfp: support IPsec offloading for NFP3800

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 9 Feb 2023 13:54:34 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Simon Horman <simon.horman@...igine.com>
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Steffen Klassert <steffen.klassert@...unet.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Chentian Liu <chengtian.liu@...igine.com>,
        Huanhuan Wang <huanhuan.wang@...igine.com>,
        Niklas Söderlund 
        <niklas.soderlund@...igine.com>, netdev@...r.kernel.org,
        oss-drivers@...igine.com
Subject: Re: [PATCH v2 net-next v2] nfp: support IPsec offloading for NFP3800

On Wed, Feb 08, 2023 at 10:10:00AM +0100, Simon Horman wrote:
> From: Huanhuan Wang <huanhuan.wang@...igine.com>
> 
> Add IPsec offloading support for NFP3800. Include data
> plane and control plane.
> 
> Data plane: add IPsec packet process flow in NFP3800
> datapath (NFDk).
> 
> Control plane: add an algorithm support distinction flow
> in xfrm hook function xdo_dev_state_add(), as NFP3800 has
> a different set of IPsec algorithm support.
> 
> This matches existing support for the NFP6000/NFP4000 and
> their NFD3 datapath.
> 
> In addition, fixup the md_bytes calculation for NFD3 datapath
> to make sure the two datapahts are keept in sync.
> 
> Signed-off-by: Huanhuan Wang <huanhuan.wang@...igine.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund@...igine.com>
> Signed-off-by: Simon Horman <simon.horman@...igine.com>
> ---
> Changes in v2:
> * use NL_SET_ERR_MSG_MOD instead of nn_err in nfp_net_xfrm_add_state()
> * Avoid using boolean values as integers
> ---
>  drivers/net/ethernet/netronome/nfp/Makefile   |  2 +-
>  .../net/ethernet/netronome/nfp/crypto/ipsec.c |  9 ++++
>  drivers/net/ethernet/netronome/nfp/nfd3/dp.c  | 11 ++---
>  drivers/net/ethernet/netronome/nfp/nfdk/dp.c  | 49 +++++++++++++++++--
>  .../net/ethernet/netronome/nfp/nfdk/ipsec.c   | 17 +++++++
>  .../net/ethernet/netronome/nfp/nfdk/nfdk.h    |  8 +++
>  6 files changed, 83 insertions(+), 13 deletions(-)
>  create mode 100644 drivers/net/ethernet/netronome/nfp/nfdk/ipsec.c
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>