netdev - Re: [PATCH RFC] linux: net: phy: realtek: changing LED behaviour for RTL8211F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230209123917.GA1550@optiplex>
Date:   Thu, 9 Feb 2023 13:39:17 +0100
From:   Oliver Graute <oliver.graute@...oconnector.com>
To:     Simon Horman <simon.horman@...igine.com>
Cc:     andrew@...n.ch, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH RFC] linux: net: phy: realtek: changing LED behaviour for
 RTL8211F

On 09/02/23, Simon Horman wrote:
> On Thu, Feb 09, 2023 at 10:44:05AM +0100, Oliver Graute wrote:
> > This enable the LEDs for network activity and 100/1000Link for the RTL8211F
> > 
> > Signed-off-by: Oliver Graute <oliver.graute@...oconnector.com>
> > ---
> >  drivers/net/phy/realtek.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
> > index 3d99fd6664d7..5c796883cad3 100644
> > --- a/drivers/net/phy/realtek.c
> > +++ b/drivers/net/phy/realtek.c
> > @@ -416,6 +416,11 @@ static int rtl8211f_config_init(struct phy_device *phydev)
> >  		}
> >  	}
> >  
> > +        phy_write(phydev, RTL821x_PAGE_SELECT, 0xd04);
> > +        phy_write(phydev, 0x10, 0x15B);
> > +
> > +        phy_write(phydev, RTL821x_PAGE_SELECT, 0x0);
> > +
> 
> nit: it looks like the indentation in the new lines above should
>      be using a single tab rather than 8 spaces.

thx, I will fix the indentation. 

is this the right place to turn on the realtek phy LEDs for RTL8211F?

Best regards,

Oliver