[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y+T4aoefc1XWvGYb@kili>
Date: Thu, 9 Feb 2023 16:43:06 +0300
From: Dan Carpenter <error27@...il.com>
To: Jiawen Wu <jiawenwu@...stnetic.com>
Cc: Mengyuan Lou <mengyuanlou@...-swift.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
kernel-janitors@...r.kernel.org
Subject: [PATCH net-next] net: libwx: fix an error code in
wx_alloc_page_pool()
This function always returns success. We need to preserve the error
code before setting rx_ring->page_pool = NULL.
Fixes: 850b971110b2 ("net: libwx: Allocate Rx and Tx resources")
Signed-off-by: Dan Carpenter <error27@...il.com>
---
Applies to net-next.
drivers/net/ethernet/wangxun/libwx/wx_lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/wangxun/libwx/wx_lib.c b/drivers/net/ethernet/wangxun/libwx/wx_lib.c
index 57e1871ea0c6..ca92fe19a663 100644
--- a/drivers/net/ethernet/wangxun/libwx/wx_lib.c
+++ b/drivers/net/ethernet/wangxun/libwx/wx_lib.c
@@ -1745,8 +1745,8 @@ static int wx_alloc_page_pool(struct wx_ring *rx_ring)
rx_ring->page_pool = page_pool_create(&pp_params);
if (IS_ERR(rx_ring->page_pool)) {
- rx_ring->page_pool = NULL;
ret = PTR_ERR(rx_ring->page_pool);
+ rx_ring->page_pool = NULL;
}
return ret;
--
2.35.1
Powered by blists - more mailing lists