[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y+T7MAu0/s1bjYIt@lunn.ch>
Date: Thu, 9 Feb 2023 14:54:56 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Md Danish Anwar <a0501179@...com>
Cc: Roger Quadros <rogerq@...nel.org>,
MD Danish Anwar <danishanwar@...com>,
"Andrew F. Davis" <afd@...com>, Suman Anna <s-anna@...com>,
YueHaibing <yuehaibing@...wei.com>,
Vignesh Raghavendra <vigneshr@...com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Jakub Kicinski <kuba@...nel.org>,
Eric Dumazet <edumazet@...gle.com>,
"David S. Miller" <davem@...emloft.net>, nm@...com,
ssantosh@...nel.org, srk@...com, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, netdev@...r.kernel.org,
linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [EXTERNAL] Re: [EXTERNAL] Re: [EXTERNAL] Re: [PATCH v4 2/2] net:
ti: icssg-prueth: Add ICSSG ethernet driver
> Sure, I'll do that. In the list of all phy modes described in [1], I can only
> see phy-mode "rgmii-txid", for which we can return -EINVAL. Is there any other
> phy-mode that requires enabling/disabling TX internal delays? Please let me
> know if any other phy-mode also needs this. I will add check for that as well.
There are 4 phy-modes for RGMII.
rgmii, rgmii-id, rmgii-rxid, rgmii-txid.
rgmii-id, rgmii-txid both require TX delays. If you do that in the MAC
you then need to pass rgmii-rxid and rgmii to the PHY respectively.
rmii and rgmii-rxid requires no TX delays, which your SoC cannot do,
so you need to return -EINVAl,
The interpretation of these properties is all really messy and
historically not very uniformly done. Which is why i recommend the MAC
does nothing, leaving it to the PHY. That generally works since the
PHYs have a pretty uniform implementation. But in your case, you don't
have that option. So i suggest you do what is described above.
Andrew
Powered by blists - more mailing lists