netdev - Re: [PATCH] net: fec: Defer probe if other FEC has deferred MDIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e3497a4b2b690d0b946601f2eae7779bac772555.camel@siemens.com>
Date:   Thu, 9 Feb 2023 14:14:33 +0000
From:   "Sverdlin, Alexander" <alexander.sverdlin@...mens.com>
To:     "andrew@...n.ch" <andrew@...n.ch>
CC:     "wei.fang@....com" <wei.fang@....com>,
        "xiaoning.wang@....com" <xiaoning.wang@....com>,
        "shenwei.wang@....com" <shenwei.wang@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-imx@....com" <linux-imx@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: fec: Defer probe if other FEC has deferred MDIO

Hello Andrew,

On Thu, 2023-02-09 at 14:35 +0100, Andrew Lunn wrote:
> > You are right, there is unfortunately no i.MX8 support in the
> > upstream
> > tree, so it's not possible to reproduce anything.
> 
> commit 947240ebcc635ab063f17ba027352c3a474d2438
> Author: Fugang Duan <fugang.duan@....com>
> Date:   Wed Jul 28 19:51:59 2021 +0800
> 
>     net: fec: add imx8mq and imx8qm new versions support
>     
>     The ENET of imx8mq and imx8qm are basically the same as imx6sx,
>     but they have new features support based on imx6sx, like:
>     - imx8mq: supports IEEE 802.3az EEE standard.
>     - imx8qm: supports RGMII mode delayed clock.
> 
> Are you using some other imx8 SoC?

I'm referring to imx8qxp/imx8dxp and my "git diff --stat" shows
that upstream has only 9% of LoCs used to boot this SoC.
There is a bit more than just Ethernet in it...

I however believe that my patch preserved the legacy behavior, in
DT-less cases and cases with only one of the two FEC ports enabled
in DT. But I can maintain the patch locally as well if there
is no interest to this fix.

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com