netdev - Re: [PATCH 1/2] iwl4965: Add missing check for create_singlethread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20230209011121.45509-1-jiasheng@iscas.ac.cn>
Date:   Thu,  9 Feb 2023 09:11:21 +0800
From:   Jiasheng Jiang <jiasheng@...as.ac.cn>
To:     stf_xl@...pl
Cc:     kvalo@...nel.org, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jiasheng Jiang <jiasheng@...as.ac.cn>
Subject: Re: [PATCH 1/2] iwl4965: Add missing check for create_singlethread_workqueue

On Thu, Feb 09, 2023 at 04:16:58AM +0800, Stanislaw Gruszka wrote:
> On Wed, Feb 08, 2023 at 02:30:31PM +0800, Jiasheng Jiang wrote:
>> Add the check for the return value of the create_singlethread_workqueue
>> in order to avoid NULL pointer dereference.
>> 
>> Fixes: b481de9ca074 ("[IWLWIFI]: add iwlwifi wireless drivers")
>> Signed-off-by: Jiasheng Jiang <jiasheng@...as.ac.cn>
> Acked-by: Stanislaw Gruszka <stf_xl@...pl>
> 
>>  static void
>> @@ -6618,7 +6622,11 @@ il4965_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>>  		goto out_disable_msi;
>>  	}
>>  
>> -	il4965_setup_deferred_work(il);
>> +	err = il4965_setup_deferred_work(il);
>> +	if (err) {
>> +		goto out_free_irq;
>> +	}
> 
> {} not needded.

I have submitted a v2 removing the "{}" with your Ack.

Thanks,
Jiang