[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y+UjMZre+qzqO4Th@corigine.com>
Date: Thu, 9 Feb 2023 17:45:37 +0100
From: Simon Horman <simon.horman@...igine.com>
To: Jiri Pirko <jiri@...nulli.us>
Cc: netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
pabeni@...hat.com, edumazet@...gle.com, tariqt@...dia.com,
saeedm@...dia.com, jacob.e.keller@...el.com, gal@...dia.com,
kim.phillips@....com, moshe@...dia.com
Subject: Re: [patch net-next 5/7] devlink: convert param list to xarray
On Thu, Feb 09, 2023 at 04:43:06PM +0100, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...dia.com>
>
> Loose the linked list for params and use xarray instead.
I gather this is related to:
[patch net-next 6/7] devlink: allow to call
devl_param_driverinit_value_get() without holding instance lock
Perhaps it is worth mentioning that here.
> Signed-off-by: Jiri Pirko <jiri@...dia.com>
Irregardless, this looks good to me.
Reviewed-by: Simon Horman <simon.horman@...igine.com>
...
> diff --git a/net/devlink/leftover.c b/net/devlink/leftover.c
> index bbace07ff063..805c2b7ff468 100644
> --- a/net/devlink/leftover.c
> +++ b/net/devlink/leftover.c
> @@ -3954,26 +3954,22 @@ static int devlink_param_driver_verify(const struct devlink_param *param)
...
> static struct devlink_param_item *
> -devlink_param_find_by_id(struct list_head *param_list, u32 param_id)
> +devlink_param_find_by_id(struct xarray *params, u32 param_id)
> {
> - struct devlink_param_item *param_item;
> -
> - list_for_each_entry(param_item, param_list, list)
> - if (param_item->param->id == param_id)
> - return param_item;
> - return NULL;
> + return xa_load(params, param_id);
> }
This change is particularly pleasing :)
...
Powered by blists - more mailing lists