[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y+UmAuVZCoRS5u/s@shell.armlinux.org.uk>
Date: Thu, 9 Feb 2023 16:57:38 +0000
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Clark Wang <xiaoning.wang@....com>
Cc: peppe.cavallaro@...com, alexandre.torgue@...s.st.com,
joabreu@...opsys.com, davem@...emloft.net, edumazet@...gle.com,
kuba@...nel.org, pabeni@...hat.com, mcoquelin.stm32@...il.com,
andrew@...n.ch, hkallweit1@...il.com, netdev@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-imx@....com
Subject: Re: [PATCH V3 1/2] net: phylink: add a function to resume phy alone
to fix resume issue with WoL enabled
Hi Clark,
Please address Jakub's points and resend with patch 2, thanks. Also,
the subject line should indicate which tree this patch series is
targetting - e.g.
[PATCH net-next v4 1/2] net: phylink: ...
> +/**
> + * phylink_phy_resume() - resume phy alone
> + * @pl: a pointer to a &struct phylink returned from phylink_create()
> + *
> + * In the MAC driver using phylink, if the MAC needs the clock of the phy
> + * when it resumes, can call this function to resume the phy separately.
> + * Then proceed to MAC resume operations.
Please also state that it must only be called prior to calling
phylink_start() in the driver's resume function.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
Powered by blists - more mailing lists