netdev - Re: [PATCH net] ice: xsk: Fix cleaning of XDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a2af75b3-3dc2-0e83-558f-2b9a4ccfe5c7@intel.com>
Date:   Thu, 9 Feb 2023 09:20:27 -0800
From:   Tony Nguyen <anthony.l.nguyen@...el.com>
To:     "Zaremba, Larysa" <larysa.zaremba@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>
CC:     "intel-wired-lan@...osl.org" <intel-wired-lan@...osl.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "Lobakin, Alexandr" <alexandr.lobakin@...el.com>,
        "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>
Subject: Re: [PATCH net] ice: xsk: Fix cleaning of XDP_TX frames

On 2/9/2023 8:01 AM, Zaremba, Larysa wrote:
> Incrementation of xsk_frames inside the for-loop produces
> infinite loop, if we have both normal AF_XDP-TX and XDP_TXed
> buffers to complete.
> 
> Split xsk_frames into 2 variables (xsk_frames and completed_frames)
> to eliminate this bug.
> 
> Fixes: 29322791bc8b ("ice: xsk: change batched Tx descriptor cleaning")
> Acked-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> Signed-off-by: Larysa Zaremba <larysa.zaremba@...el.com>
> ---
> To Tony: this is urgent and should go directly via net. It's tested and acked.

netdev maintainers,

Since it's been tested and reviewed, did you want to take this directly?

Acked-by: Tony Nguyen <anthony.l.nguyen@...el.com>