netdev - Re: [PATCH] wifi: rt2x00: remove impossible test condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20230209181046.GA1446693@wp.pl>
Date:   Thu, 9 Feb 2023 19:10:46 +0100
From:   Stanislaw Gruszka <stf_xl@...pl>
To:     Deepak R Varma <drv@...lo.com>
Cc:     Helmut Schaa <helmut.schaa@...glemail.com>,
        Kalle Valo <kvalo@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Saurabh Singh Sengar <ssengar@...rosoft.com>,
        Praveen Kumar <kumarpraveen@...ux.microsoft.com>
Subject: Re: [PATCH] wifi: rt2x00: remove impossible test condition

On Thu, Feb 09, 2023 at 02:35:50PM +0530, Deepak R Varma wrote:
> Variable vga_gain is a u8 and will never attain a value less than 0.
> Hence testing it for less 0 is impossible.
> Issue identified using unsigned_lesser_than_zero.cocci Coccinelle
> semantic patch. The issue was also reported by Kernel test Robot.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Deepak R Varma <drv@...lo.com>
Acked-by: Stanislaw Gruszka <stf_xl@...pl>