[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230209122153.2b02faf4@kernel.org>
Date: Thu, 9 Feb 2023 12:21:53 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Haiyang Zhang <haiyangz@...rosoft.com>
Cc: "Michael Kelley (LINUX)" <mikelley@...rosoft.com>,
KY Srinivasan <kys@...rosoft.com>,
"wei.liu@...nel.org" <wei.liu@...nel.org>,
Dexuan Cui <decui@...rosoft.com>,
"davem@...emloft.net" <davem@...emloft.net>,
"edumazet@...gle.com" <edumazet@...gle.com>,
"pabeni@...hat.com" <pabeni@...hat.com>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 1/1] hv_netvsc: Check status in SEND_RNDIS_PKT
completion message
On Thu, 9 Feb 2023 19:10:16 +0000 Haiyang Zhang wrote:
> But I'm just worried about if a VM sending at high speed, and host side is,
> for some reason, not able to send them correctly, the log file will become
> really big and difficult to download and read. With rate limit, we still see
> dozens of messages every 5 seconds or so, and it tells you how many
> messages are skipped. And, if the rate is lower, it won't skip anything.
> Isn't this info sufficient to debug?
>
> By the way, guests cannot trust the host -- probably we shouldn't allow the
> host to have a way to jam guest's log file?
+1 FWIW, the general guidance is to always rate limit prints
which may be triggered from the datapath (which I'm guessing
this is based on the names of things)
Powered by blists - more mailing lists