Date:   Thu, 9 Feb 2023 15:05:46 -0600
From:   Kim Phillips <kim.phillips@....com>
To:     Jiri Pirko <jiri@...nulli.us>, <netdev@...r.kernel.org>
CC:     <davem@...emloft.net>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <edumazet@...gle.com>, <tariqt@...dia.com>, <saeedm@...dia.com>,
        <jacob.e.keller@...el.com>, <gal@...dia.com>, <moshe@...dia.com>
Subject: Re: [patch net-next 0/7] devlink: params cleanups and
 devl_param_driverinit_value_get() fix

On 2/9/23 9:43 AM, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...dia.com>
> 
> The primary motivation of this patchset is the patch #6, which fixes an
> issue introduced by 075935f0ae0f ("devlink: protect devlink param list
> by instance lock") and reported by Kim Phillips <kim.phillips@....com>
> (https://lore.kernel.org/netdev/719de4f0-76ac-e8b9-38a9-167ae239efc7@amd.com/)
> and my colleagues doing mlx5 driver regression testing.

I can't provide my Tested-by because this series doesn't apply
cleanly to today's (or the original day's) linux-next tag, and
today's net-next/{master,main} (5131a053f292) won't boot on any
of my systems, whether or not this series is applied, with:

[   19.478836] ------------[ cut here ]------------
[   19.483474] kernel BUG at mm/usercopy.c:102!
[   19.487761] invalid opcode: 0000 [#1] PREEMPT SMP NOPTI
[   19.492988] CPU: 196 PID: 1903 Comm: systemd-udevd Not tainted 6.2.0-rc6+ #119
[   19.500204] Hardware name: AMD Corporation DAYTONA_X/DAYTONA_X, BIOS RDY1009A 09/16/2020
[   19.508284] RIP: 0010:usercopy_abort+0x7f/0x81
[   19.512738] Code: 4c 0f 45 de 51 4c 89 d1 48 c7 c2 7b 66 b6 9c 57 48 c7 c6 a8 b4 b5 9c 48 c7 c7 b8 4b c0 9c 48 0f 45 f2 4c 89 da e8 1e 56 ff ff <0f> 0b 49 89 d8 4c 89 c9 44 89 ea 31 f6 48 c7 c7 c5 66 b6 9c e8 68
[   19.531484] RSP: 0018:ffffaeabdc8d3ad0 EFLAGS: 00010246
[   19.536708] RAX: 000000000000006b RBX: 0000000000000053 RCX: 0000000000000000
[   19.543833] RDX: 0000000000000000 RSI: 00000000ffdfffff RDI: 00000000ffffffff
[   19.550964] RBP: ffffaeabdc8d3ae8 R08: 0000000000000000 R09: ffffaeabdc8d3950
[   19.558088] R10: 0000000000000001 R11: 0000000000000001 R12: ffff93700bf72a80
[   19.565214] R13: 0000000000000001 R14: ffff93700bf72ad3 R15: 0000000000000040
[   19.572346] FS:  00007f2b4b275880(0000) GS:ffff938e80c00000(0000) knlGS:0000000000000000
[   19.580432] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[   19.586177] CR2: 00007ffc48657b08 CR3: 000080108f998000 CR4: 0000000000350ee0
[   19.593300] Call Trace:
[   19.595746]  <TASK>
[   19.597853]  __check_heap_object+0x9f/0xe0
[   19.601950]  __check_object_size+0x1f7/0x220
[   19.606221]  simple_copy_to_iter+0x2f/0x60
[   19.610323]  __skb_datagram_iter+0x78/0x2e0
[   19.614507]  ? __pfx_simple_copy_to_iter+0x10/0x10
[   19.619300]  ? __skb_recv_datagram+0x8b/0xc0
[   19.623574]  skb_copy_datagram_iter+0x66/0xe0
[   19.627933]  netlink_recvmsg+0xd1/0x400
[   19.631772]  ? apparmor_socket_recvmsg+0x22/0x30
[   19.636391]  sock_recvmsg+0xaa/0xb0
[   19.639882]  ____sys_recvmsg+0x9b/0x200
[   19.643715]  ? import_iovec+0x1f/0x30
[   19.647379]  ? copy_msghdr_from_user+0x77/0xb0
[   19.651817]  ___sys_recvmsg+0x80/0xc0
[   19.655483]  ? __lock_acquire.isra.0+0x123/0x540
[   19.660102]  ? sched_clock+0xd/0x20
[   19.663595]  __sys_recvmsg+0x66/0xc0
[   19.667176]  __x64_sys_recvmsg+0x23/0x30
[   19.671099]  do_syscall_64+0x3f/0x90
[   19.674680]  entry_SYSCALL_64_after_hwframe+0x72/0xdc
[   19.679731] RIP: 0033:0x7f2b4b8a9487
[   19.683311] Code: 64 89 02 48 c7 c0 ff ff ff ff eb c1 0f 1f 80 00 00 00 00 f3 0f 1e fa 64 8b 04 25 18 00 00 00 85 c0 75 10 b8 2f 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 51 c3 48 83 ec 28 89 54 24 1c 48 89 74 24 10
[   19.702057] RSP: 002b:00007ffc48657968 EFLAGS: 00000246 ORIG_RAX: 000000000000002f
[   19.709623] RAX: ffffffffffffffda RBX: 000055cb525ae070 RCX: 00007f2b4b8a9487
[   19.716755] RDX: 0000000000000000 RSI: 00007ffc48657a10 RDI: 0000000000000005
[   19.723888] RBP: 00007ffc48659b40 R08: 00000000ffffffff R09: 0000000000000020
[   19.731010] R10: 000055cb525ae818 R11: 0000000000000246 R12: 0000000000000000
[   19.738134] R13: 00007ffc48657af0 R14: 000055cb522372a0 R15: 000055cb525ae1c0
[   19.745262]  </TASK>
[   19.747453] Modules linked in:
[   19.750524] ---[ end trace 0000000000000000 ]---
[   19.755148] RIP: 0010:usercopy_abort+0x7f/0x81
[   19.759598] Code: 4c 0f 45 de 51 4c 89 d1 48 c7 c2 7b 66 b6 9c 57 48 c7 c6 a8 b4 b5 9c 48 c7 c7 b8 4b c0 9c 48 0f 45 f2 4c 89 da e8 1e 56 ff ff <0f> 0b 49 89 d8 4c 89 c9 44 89 ea 31 f6 48 c7 c7 c5 66 b6 9c e8 68
[   19.778347] RSP: 0018:ffffaeabdc8d3ad0 EFLAGS: 00010246
[   19.783571] RAX: 000000000000006b RBX: 0000000000000053 RCX: 0000000000000000
[   19.790703] RDX: 0000000000000000 RSI: 00000000ffdfffff RDI: 00000000ffffffff
[   19.797838] RBP: ffffaeabdc8d3ae8 R08: 0000000000000000 R09: ffffaeabdc8d3950
[   19.804971] R10: 0000000000000001 R11: 0000000000000001 R12: ffff93700bf72a80
[   19.812102] R13: 0000000000000001 R14: ffff93700bf72ad3 R15: 0000000000000040
[   19.819236] FS:  00007f2b4b275880(0000) GS:ffff938e80c00000(0000) knlGS:0000000000000000
[   19.827330] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[   19.833075] CR2: 00007ffc48657b08 CR3: 000080108f998000 CR4: 0000000000350ee0
[   19.840545] printk: systemd-udevd: 23 output lines suppressed due to ratelimiting
[   19.864222] ------------[ cut here ]------------
[   19.868843] WARNING: CPU: 68 PID: 0 at net/netlink/af_netlink.c:414 netlink_sock_destruct+0xa1/0xc0
[   19.877886] Modules linked in:
[   19.880947] CPU: 68 PID: 0 Comm: swapper/68 Tainted: G      D            6.2.0-rc6+ #119
[   19.889033] Hardware name: AMD Corporation DAYTONA_X/DAYTONA_X, BIOS RDY1009A 09/16/2020
[   19.897119] RIP: 0010:netlink_sock_destruct+0xa1/0xc0
[   19.902172] Code: 29 41 8b 84 24 9c 02 00 00 85 c0 75 2b 49 83 bc 24 68 05 00 00 00 75 08 41 5c 5d e9 bd ac 28 00 0f 0b 41 5c 5d e9 b3 ac 28 00 <0f> 0b 41 8b 84 24 9c 02 00 00 85 c0 74 d5 0f 0b eb d1 66 66 2e 0f
[   19.920916] RSP: 0018:ffffaeab87e3ce38 EFLAGS: 00010202
[   19.926140] RAX: 0000000000000380 RBX: ffff937ed3c27d30 RCX: 0000000000000000
[   19.933274] RDX: 0000000000000102 RSI: ffffffff9bf21a23 RDI: 0000000000000000
[   19.940406] RBP: ffffaeab87e3ce40 R08: 0000000000000001 R09: 0000000000000000
[   19.947539] R10: 0000000000000000 R11: 0000000000000000 R12: ffff937ed3c27800
[   19.954672] R13: ffff937ed3c27f30 R14: ffff937ed3304b80 R15: ffffaeab87e3cf20
[   19.961804] FS:  0000000000000000(0000) GS:ffff938e70c00000(0000) knlGS:0000000000000000
[   19.969889] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[   19.975637] CR2: 0000000000000000 CR3: 0000800ade212000 CR4: 0000000000350ee0
[   19.982771] Call Trace:
[   19.985221]  <IRQ>
[   19.987237]  __sk_destruct+0x33/0x230
[   19.990906]  ? deferred_put_nlk_sk+0x1d/0x100
[   19.995265]  sk_destruct+0x52/0x60
[   19.998672]  __sk_free+0x30/0xd0
[   20.001902]  sk_free+0x2e/0x50
[   20.004964]  deferred_put_nlk_sk+0x6b/0x100
[   20.009148]  rcu_core+0x4c2/0x7a0
[   20.012467]  ? rcu_core+0x47e/0x7a0
[   20.015961]  rcu_core_si+0x12/0x20
[   20.019366]  __do_softirq+0x11f/0x353
[   20.023034]  irq_exit_rcu+0xaf/0xe0
[   20.026533]  sysvec_apic_timer_interrupt+0xb4/0xd0
[   20.031326]  </IRQ>
[   20.033432]  <TASK>
[   20.035536]  asm_sysvec_apic_timer_interrupt+0x1f/0x30
[   20.040679] RIP: 0010:cpuidle_enter_state+0x126/0x4d0
[   20.045738] Code: 00 31 ff e8 bc f9 46 ff 80 7d d7 00 74 16 9c 58 0f 1f 40 00 f6 c4 02 0f 85 8e 03 00 00 31 ff e8 d0 19 4f ff fb 0f 1f 44 00 00 <45> 85 ff 0f 88 d9 01 00 00 49 63 c7 4c 2b 75 c8 48 8d 14 40 48 8d
[   20.064484] RSP: 0018:ffffaeab80797e48 EFLAGS: 00000246
[   20.069711] RAX: ffff938e70c00000 RBX: 0000000000000002 RCX: 000000000000001f
[   20.076844] RDX: 0000000000000000 RSI: ffffffff9cb59380 RDI: ffffffff9cb5eaaf
[   20.083973] RBP: ffffaeab80797e80 R08: 000000049ffc9237 R09: 0000000000000e04
[   20.091110] R10: ffff938e70df3964 R11: ffff938e70df3944 R12: ffff9370025afc00
[   20.098240] R13: ffffffff9d35b180 R14: 000000049ffc9237 R15: 0000000000000002
[   20.105377]  ? cpuidle_enter_state+0x104/0x4d0
[   20.109819]  cpuidle_enter+0x32/0x50
[   20.113397]  call_cpuidle+0x23/0x50
[   20.116892]  do_idle+0x1d4/0x250
[   20.120123]  cpu_startup_entry+0x24/0x30
[   20.124051]  start_secondary+0x114/0x130
[   20.127974]  secondary_startup_64_no_verify+0xd3/0xdb
[   20.133032]  </TASK>
[   20.135218] ---[ end trace 0000000000000000 ]---
[   21.988002] raid6: avx2x4   gen() 27873 MB/s
[   22.060002] raid6: avx2x2   gen() 28291 MB/s
[   22.132001] raid6: avx2x1   gen() 23642 MB/s
[   22.136275] raid6: using algorithm avx2x2 gen() 28291 MB/s
[   22.208001] raid6: .... xor() 17406 MB/s, rmw enabled
[   22.213051] raid6: using avx2x2 recovery algorithm
[   22.222249] xor: automatically using best checksumming function   avx
[   22.234862] async_tx: api initialized (async)
[   22.555209] Btrfs loaded, crc32c=crc32c-intel, zoned=yes, fsverity=yes

(it then drops to the initramfs prompt).

Is there a different tree the series can be rebased on, until net-next
gets fixed?

Thanks,

Kim

Powered by blists - more mailing lists