netdev - Re: pull-request: mlx5-next netdev notifier deadlock 2023-02-07

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230208191250.45b23b6f@kernel.org>
Date:   Wed, 8 Feb 2023 19:12:50 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Saeed Mahameed <saeed@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Jason Gunthorpe <jgg@...dia.com>,
        Saeed Mahameed <saeedm@...dia.com>, linux-rdma@...r.kernel.org,
        Leon Romanovsky <leonro@...dia.com>, netdev@...r.kernel.org
Subject: Re: pull-request: mlx5-next netdev notifier deadlock 2023-02-07

On Tue,  7 Feb 2023 16:56:26 -0800 Saeed Mahameed wrote:
> @@ -674,6 +675,7 @@ struct mlx5e_resources {
>  	} hw_objs;
>  	struct devlink_port dl_port;
>  	struct net_device *uplink_netdev;
> +	struct mutex uplink_netdev_lock;

Is this your preferred resolution?

diff --cc include/linux/mlx5/driver.h
index 91e8160ed087,cc48aa308269..000000000000
--- a/include/linux/mlx5/driver.h
+++ b/include/linux/mlx5/driver.h
@@@ -670,11 -673,11 +671,12 @@@ struct mlx5e_resources 
                u32                        mkey;
                struct mlx5_sq_bfreg       bfreg;
        } hw_objs;
        struct devlink_port dl_port;
        struct net_device *uplink_netdev;
+       struct mutex uplink_netdev_lock;
 +      struct mlx5_crypto_dek_priv *dek_priv;
  };
  
  enum mlx5_sw_icm_type {
        MLX5_SW_ICM_TYPE_STEERING,
        MLX5_SW_ICM_TYPE_HEADER_MODIFY,