netdev - Re: [PATCH net-next 2/4] gve: Add XDP DROP and TX support for GQI-QPL format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230208215452.67225287@kernel.org>
Date:   Wed, 8 Feb 2023 21:54:52 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Praveen Kaligineedi <pkaligineedi@...gle.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        Jeroen de Borst <jeroendb@...gle.com>
Subject: Re: [PATCH net-next 2/4] gve: Add XDP DROP and TX support for
 GQI-QPL format

On Tue,  7 Feb 2023 13:00:56 -0800 Praveen Kaligineedi wrote:
> +		// Adding/removing a program, need to recreate the queues.
> +		if (!netif_carrier_ok(priv->dev)) {
> +			rcu_assign_pointer(priv->xdp_prog, prog);
> +			goto out;
> +		}
> +		err = gve_close(priv->dev);
> +		if (err)
> +			return err;
> +
> +		rcu_assign_pointer(priv->xdp_prog, prog);
> +		gve_open(priv->dev);

And if open() fails e.g. due to transient memory pressure the machine
drops off the network and success gets returned to user space?
We have been asking driver developers for a while now to allocate
resources first, then try the reconfig.