netdev - Re: [PATCH v3 net-next 3/3] ionic: add support for device Component Memory Buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c2cde083-3d7a-5fda-5970-ebfc6413f43d@amd.com>
Date:   Wed, 8 Feb 2023 22:52:59 -0800
From:   Shannon Nelson <shannon.nelson@....com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, drivers@...sando.io
Subject: Re: [PATCH v3 net-next 3/3] ionic: add support for device Component
 Memory Buffers

On 2/8/23 9:50 PM, Jakub Kicinski wrote:
> On Tue, 7 Feb 2023 15:40:06 -0800 Shannon Nelson wrote:
>> The ionic device has on-board memory (CMB) that can be used
>> for descriptors as a way to speed descriptor access for faster
>> traffic processing.  It is best used to improve latency and
>> packets-per-second for some profiles of small packet traffic.
>> It is not on by default, but can be enabled through the ethtool
>> priv-flags when the interface is down.
> 
> Oh, completely missed this when looking at previous version.
> This is ETHTOOL_A_RINGS_TX_PUSH right?
> 
> Could you take a look at what hns3 does to confirm?

Hmmm... I hadn't seen that feature creep in.  I guess I'll have to hunt 
down an up-to-date ethtool and experiment a bit.

Yes, on first glance this looks similar, except we do both TX and RX 
descriptors when CMB is enabled.

I'll look at this more tomorrow and see what it might take to roll it 
together.

sln