netdev - Re: [PATCH v4 2/2] Bluetooth: btrtl: add support for the RTL8723CS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+E=qVdLhyJYj-53+OSgpLQcTXY=H4TsVb-UFQYhMSkHZJj4hA@mail.gmail.com>
Date:   Wed, 8 Feb 2023 23:14:19 -0800
From:   Vasily Khoruzhick <anarsoul@...il.com>
To:     Marcel Holtmann <marcel@...tmann.org>
Cc:     Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        Bastian Germann <bage@...ian.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        BlueZ <linux-bluetooth@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>, netdev@...r.kernel.org
Subject: Re: [PATCH v4 2/2] Bluetooth: btrtl: add support for the RTL8723CS

On Wed, Feb 8, 2023 at 11:02 PM Marcel Holtmann <marcel@...tmann.org> wrote:

Hi Marcel,

> Hi Luiz,
>
> >> The Realtek RTL8723CS is a SDIO WiFi chip. It also contains a Bluetooth
> >> module which is connected via UART to the host.
> >>
> >> It shares lmp subversion with 8703B, so Realtek's userspace
> >> initialization tool (rtk_hciattach) differentiates varieties of RTL8723CS
> >> (CG, VF, XX) with RTL8703B using vendor's command to read the chip type.
> >
> > Don't remember anything called rtk_hciattach, besides if that is based
> > on hciattach that is already deprecated in favor of btattach.
>
> and btattach is also deprecated. Write a proper serdev based driver.

It is already a proper serdev based driver. rtk_hciattach is only
mentioned to explain how differentiating the chips was implemented
prior to this driver.

Regards,
Vasily

> The hci_ldisc line discipline crap needs to be removed.
>
> Regards
>
> Marcel
>