netdev - error: too many arguments to function ‘can_calc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 9 Feb 2023 17:56:53 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Network Development <netdev@...r.kernel.org>,
        linux-can@...r.kernel.og
Cc:     Wolfgang Grandegger <wg@...ndegger.com>,
        Marc Kleine-Budde <mkl@...gutronix.de>
Subject: error: too many arguments to function ‘can_calc_bittiming’

Hi,

It's possible to have a kernel .config (randconfig) file with
# CONFIG_CAN_CALC_BITTIMING is not set

which ends up with different number of arguments to can_calc_bittiming().

Full compiler error listing is:

../drivers/net/can/dev/bittiming.c: In function ‘can_get_bittiming’:
../drivers/net/can/dev/bittiming.c:145:24: error: too many arguments to function ‘can_calc_bittiming’
  145 |                 return can_calc_bittiming(dev, bt, btc, extack);
      |                        ^~~~~~~~~~~~~~~~~~
In file included from ../include/linux/can/dev.h:18,
                 from ../drivers/net/can/dev/bittiming.c:7:
../include/linux/can/bittiming.h:126:1: note: declared here
  126 | can_calc_bittiming(const struct net_device *dev, struct can_bittiming *bt,
      | ^~~~~~~~~~~~~~~~~~


A failing i386 .config file is attached.

Do you have any suggestions for resolving this error?

Thank you.
-- 
~Randy
View attachment "xx32-config-can-timing" of type "text/plain" (140558 bytes)