netdev - Re: [PATCH v6 net-next 2/8] sfc: add devlink info support for ef100

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y+Yw3UHO9ZWzyYZa@nanopsycho>
Date:   Fri, 10 Feb 2023 12:56:13 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     "Lucero Palau, Alejandro" <alejandro.lucero-palau@....com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-net-drivers (AMD-Xilinx)" <linux-net-drivers@....com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "habetsm.xilinx@...il.com" <habetsm.xilinx@...il.com>,
        "ecree.xilinx@...il.com" <ecree.xilinx@...il.com>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "corbet@....net" <corbet@....net>,
        "jiri@...dia.com" <jiri@...dia.com>
Subject: Re: [PATCH v6 net-next 2/8] sfc: add devlink info support for ef100

Thu, Feb 09, 2023 at 11:46:04AM CET, alejandro.lucero-palau@....com wrote:
>
>On 2/8/23 15:24, Lucero Palau, Alejandro wrote:
>> On 2/8/23 14:38, Jiri Pirko wrote:
>>> Wed, Feb 08, 2023 at 03:25:13PM CET, alejandro.lucero-palau@....com wrote:
>>>> From: Alejandro Lucero <alejandro.lucero-palau@....com>
>>> [..]
>>>
>>>
>>>> +static int efx_devlink_info_get(struct devlink *devlink,
>>>> +				struct devlink_info_req *req,
>>>> +				struct netlink_ext_ack *extack)
>>>> +{
>>>> +	struct efx_devlink *devlink_private = devlink_priv(devlink);
>>>> +	struct efx_nic *efx = devlink_private->efx;
>>>> +	int rc;
>>>> +
>>>> +	/* Several different MCDI commands are used. We report first error
>>>> +	 * through extack along with total number of errors. Specific error
>>>> +	 * information via system messages.
>>> I think you forgot to remove this comment.
>>>
>>> With this nit fixed, free free to add:
>>> Reviewed-by: Jiri Pirko <jiri@...dia.com>
>>>
>> I'll do.
>>
>> Thanks
>
>Just wondering if this single nit deserves a v7 or better to delay it as 
>another patch.
>
>We got another patchset for ef100 ready to be sent and we would prefer 
>to not delay this one more than needed.

Cleaner would be v7, but I don't mind that much. Let the patchbot to
decide :)