netdev - Re: [PATCH v3 net 2/2] net: Remove WARN_ON_ONCE(sk->sk_forward_alloc) from sk_stream_kill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJAqDMWVXR9x3DuzTkQRZKwUNivxh1b=iYPMQ5eNO+q+Q@mail.gmail.com>
Date:   Fri, 10 Feb 2023 15:13:10 +0100
From:   Eric Dumazet <edumazet@...gle.com>
To:     Kuniyuki Iwashima <kuniyu@...zon.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org,
        syzbot <syzkaller@...glegroups.com>,
        Christoph Paasch <christophpaasch@...oud.com>,
        Matthieu Baerts <matthieu.baerts@...sares.net>
Subject: Re: [PATCH v3 net 2/2] net: Remove WARN_ON_ONCE(sk->sk_forward_alloc)
 from sk_stream_kill_queues().

On Fri, Feb 10, 2023 at 1:23 AM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
>
> Christoph Paasch reported that commit b5fc29233d28 ("inet6: Remove
> inet6_destroy_sock() in sk->sk_prot->destroy().") started triggering
> WARN_ON_ONCE(sk->sk_forward_alloc) in sk_stream_kill_queues().  [0 - 2]
> Also, we can reproduce it by a program in [3].
>
> In the commit, we delay freeing ipv6_pinfo.pktoptions from sk->destroy()
> to sk->sk_destruct(), so sk->sk_forward_alloc is no longer zero in
> inet_csk_destroy_sock().
>
Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks !