netdev - Re: [PATCH 03/14] Move COMPAT_ATM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <2344ac16-781e-8bfa-ec75-e71df0f3ed28@redhat.com>
Date:   Fri, 10 Feb 2023 15:55:45 +0100
From:   Thomas Huth <thuth@...hat.com>
To:     Palmer Dabbelt <palmer@...belt.com>, linux-api@...r.kernel.org,
        linux-kernel@...r.kernel.org, davem@...emloft.net,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Cc:     viro@...iv.linux.org.uk, aishchuk@...ux.vnet.ibm.com,
        aarcange@...hat.com, akpm@...ux-foundation.org, luto@...nel.org,
        acme@...nel.org, bhe@...hat.com, 3chas3@...il.com,
        chris@...kel.net, dave@...1.net, dyoung@...hat.com,
        drysdale@...gle.com, ebiederm@...ssion.com, geoff@...radead.org,
        gregkh@...uxfoundation.org, hpa@...or.com, mingo@...nel.org,
        iulia.manda21@...il.com, plagnioj@...osoft.com, jikos@...nel.org,
        josh@...htriplett.org, linux-arch@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, mathieu.desnoyers@...icios.com,
        jcmvbkbc@...il.com, paulmck@...ux.vnet.ibm.com,
        a.p.zijlstra@...llo.nl, tglx@...utronix.de, vgoyal@...hat.com,
        x86@...nel.org, arnd@...db.de, dhowells@...hat.com,
        peterz@...radead.org, netdev@...r.kernel.org
Subject: Re: [PATCH 03/14] Move COMPAT_ATM_ADDPARTY to net/atm/svc.c

On 10/11/2015 02.31, Palmer Dabbelt wrote:
> This used to be behind an #ifdef COMPAT_COMPAT, so most of userspace
> wouldn't have seen the definition before.  Unfortunately this header
> file became visible to userspace, so the definition has instead been
> moved to net/atm/svc.c (the only user).
> 
> Signed-off-by: Palmer Dabbelt <palmer@...belt.com>
> Reviewed-by: Andrew Waterman <waterman@...s.berkeley.edu>
> Reviewed-by: Albert Ou <aou@...s.berkeley.edu>
> ---
>   include/uapi/linux/atmdev.h | 4 ----
>   net/atm/svc.c               | 5 +++++
>   2 files changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/include/uapi/linux/atmdev.h b/include/uapi/linux/atmdev.h
> index 93e0ec0..3dcec70 100644
> --- a/include/uapi/linux/atmdev.h
> +++ b/include/uapi/linux/atmdev.h
> @@ -100,10 +100,6 @@ struct atm_dev_stats {
>   					/* use backend to make new if */
>   #define ATM_ADDPARTY  	_IOW('a', ATMIOC_SPECIAL+4,struct atm_iobuf)
>    					/* add party to p2mp call */
> -#ifdef CONFIG_COMPAT
> -/* It actually takes struct sockaddr_atmsvc, not struct atm_iobuf */
> -#define COMPAT_ATM_ADDPARTY  	_IOW('a', ATMIOC_SPECIAL+4,struct compat_atm_iobuf)
> -#endif
>   #define ATM_DROPPARTY 	_IOW('a', ATMIOC_SPECIAL+5,int)
>   					/* drop party from p2mp call */
>   
> diff --git a/net/atm/svc.c b/net/atm/svc.c
> index 3fa0a9e..9e2e6ef 100644
> --- a/net/atm/svc.c
> +++ b/net/atm/svc.c
> @@ -27,6 +27,11 @@
>   #include "signaling.h"
>   #include "addr.h"
>   
> +#ifdef CONFIG_COMPAT
> +/* It actually takes struct sockaddr_atmsvc, not struct atm_iobuf */
> +#define COMPAT_ATM_ADDPARTY _IOW('a', ATMIOC_SPECIAL+4, struct compat_atm_iobuf)
> +#endif
> +
>   static int svc_create(struct net *net, struct socket *sock, int protocol,
>   		      int kern);
>   

  Hi!

The CONFIG_* switch is still there in the atmdev.h uapi header ... could 
somebody please pick this patch up to fix it?

  Thanks,
   Thomas