netdev - Re: [patch net-next v2 5/7] devlink: convert param list to xarray

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3e6ddb39-02dc-ec30-0085-0a9c70664c5e@intel.com>
Date:   Fri, 10 Feb 2023 11:37:50 -0800
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Jiri Pirko <jiri@...nulli.us>, <netdev@...r.kernel.org>
CC:     <davem@...emloft.net>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <edumazet@...gle.com>, <tariqt@...dia.com>, <saeedm@...dia.com>,
        <gal@...dia.com>, <kim.phillips@....com>, <moshe@...dia.com>,
        <simon.horman@...igine.com>, <idosch@...dia.com>
Subject: Re: [patch net-next v2 5/7] devlink: convert param list to xarray



On 2/10/2023 2:01 AM, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...dia.com>
> 
> Loose the linked list for params and use xarray instead.
> 
> Note that this is required to be eventually possible to call
> devl_param_driverinit_value_get() without holding instance lock.
> 
> Signed-off-by: Jiri Pirko <jiri@...dia.com>
> Reviewed-by: Simon Horman <simon.horman@...igine.com>
> Acked-by: Jakub Kicinski <kuba@...nel.org>

That makes loading by the parameter id faster too since we don't have to
iterate the full list. Nice.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>